Skip to content

fix(legal): Workaround reuse tool#1322

Closed
rzr wants to merge 1 commit intoFreeRTOS:mainfrom
rzr:review/main
Closed

fix(legal): Workaround reuse tool#1322
rzr wants to merge 1 commit intoFreeRTOS:mainfrom
rzr:review/main

Conversation

@rzr
Copy link
Copy Markdown

@rzr rzr commented Sep 26, 2025 •
edited
Loading

I noticed while using https://reuse.software/
this false positive error:

reuse.extract - ERROR - Could not parse 'MIT\n','
reuse.extract - ERROR - \
  '.../FreeRTOS-Kernel/.github/scripts/kernel_checker.py' \
  holds an SPDX expression that cannot be parsed, skipping the file

Relate-to: #1321

Description

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rzr
fix(legal): Workaround reuse tool
24ad16c 
I noticed while using https://reuse.software/
this false positive error:

    reuse.extract - ERROR - Could not parse 'MIT\n','
    reuse.extract - ERROR - \
      '.../FreeRTOS-Kernel/.github/scripts/kernel_checker.py' \
      holds an SPDX expression that cannot be parsed, skipping the file

Origin: FreeRTOS#1322
Relate-to: FreeRTOS#1321
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aggarg
Copy link
Copy Markdown
Member

aggarg commented Sep 29, 2025

This line does not need to be parsed by the tool as it is not license. Seems more like a tool limitation.

@rzr
Copy link
Copy Markdown
Author

rzr commented Sep 29, 2025

This line does not need to be parsed by the tool as it is not license. Seems more like a tool limitation.

yes i can confirm , that's why i committed as a workaround
Feel free to ignore if you think it is polluting the code, but it helped me to scan some repository that pull freertos as submodule dependency.

moninom1 pushed a commit to moninom1/FreeRTOS-Kernel that referenced this pull request Sep 30, 2025
@aggarg
Fix CI failures (FreeRTOS#1322)
642e2ec 
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@xuelix
Copy link
Copy Markdown
Contributor

xuelix commented Oct 3, 2025

The reuse tool needs to be updated in this case.
Close the PR.

@xuelix xuelix closed this Oct 3, 2025
@rzr
Copy link
Copy Markdown
Author

rzr commented Oct 4, 2025

The reuse tool needs to be updated in this case. Close the PR.

ok fair enough, I will try to forward the issue at the source

meanwhile please consider:

#1321

rzr added a commit to rzr/FreeRTOS-Kernel that referenced this pull request Oct 7, 2025
@rzr
fix(legal): Workaround reuse tool
a7a7bdb 
I noticed while using https://reuse.software/
this false positive error:

    reuse.extract - ERROR - Could not parse 'MIT\n','
    reuse.extract - ERROR - \
      '.../FreeRTOS-Kernel/.github/scripts/kernel_checker.py' \
      holds an SPDX expression that cannot be parsed, skipping the file

Origin: FreeRTOS#1322
Relate-to: FreeRTOS#1321
Relate-to: https://reuse.software/faq/#exclude-lines
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr
Copy link
Copy Markdown
Author

rzr commented Oct 7, 2025

Is this an acceptable option:

rzr@a7a7bdb

Relate-to: https://reuse.software/faq/#exclude-lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rzr @aggarg @xuelix